Remove issue and MR counts from labels index

We were performing two (quite slow, because of the need to do access checks) queries for each label on the page: one to get the count of issues with that label, and one to get the count of merge requests with that label. Until we have a performant way of doing this, remove the counts.

Remove issue and MR counts from labels index
bf93a9f5 · Sean McGivern · 35824650 · bf93a9f5 · bf93a9f5
Commit bf93a9f5 authored Feb 17, 2017 by Sean McGivern
Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 6 deletions

_label.html.haml app/views/shared/_label.html.haml +4 -6

remove-issue-and-mr-counts-from-labels-page.yml ...nreleased/remove-issue-and-mr-counts-from-labels-page.yml +4 -0

No files found.
--- a/app/views/shared/_label.html.haml
+++ b/app/views/shared/_label.html.haml
 - label_css_id = dom_id(label)
- open_issues_count = label.open_issues_count(current_user)
- open_merge_requests_count = label.open_merge_requests_count(current_user)
 - status = label_subscription_status(label, @project).inquiry if current_user
 - subject = local_assigns[:subject]

@@ -15,10 +13,10 @@
      %ul
        %li
          = link_to_label(label, subject: subject, type: :merge_request) do
-            = pluralize open_merge_requests_count, 'merge request'
+            view merge requests
        %li
          = link_to_label(label, subject: subject) do
-            = pluralize open_issues_count, 'open issue'
+            view open issues
        - if current_user && defined?(@project)
          %li.label-subscription
            - if label.is_a?(ProjectLabel)
@@ -40,9 +38,9 @@

  .pull-right.hidden-xs.hidden-sm.hidden-md
    = link_to_label(label, subject: subject, type: :merge_request, css_class: 'btn btn-transparent btn-action') do
-      = pluralize open_merge_requests_count, 'merge request'
+      view merge requests
    = link_to_label(label, subject: subject, css_class: 'btn btn-transparent btn-action') do
-      = pluralize open_issues_count, 'open issue'
+      view open issues

    - if current_user && defined?(@project)
      .label-subscription.inline

--- a/changelogs/unreleased/remove-issue-and-mr-counts-from-labels-page.yml
+++ b/changelogs/unreleased/remove-issue-and-mr-counts-from-labels-page.yml
+---
+title: Remove issue and MR counts from labels index
+merge_request:
+author: