Eager load project creators for project dashboards

This solves an N+1 query problem where for every project we'd query the creator separately just to figure out what avatar to display.

Eager load project creators for project dashboards
bd08fff6 · Yorick Peterse · ab738645 · bd08fff6 · bd08fff6
Unverified Commit bd08fff6 authored Aug 04, 2017 by Yorick Peterse
Showing with 8 additions and 2 deletions

projects_controller.rb app/controllers/dashboard/projects_controller.rb +4 -2

eager-load-project-creators-for-project-dashboards.yml ...ed/eager-load-project-creators-for-project-dashboards.yml +4 -0

No files found.
--- a/app/controllers/dashboard/projects_controller.rb
+++ b/app/controllers/dashboard/projects_controller.rb
@@ -45,8 +45,10 @@ class Dashboard::ProjectsController < Dashboard::ApplicationController
  end

  def load_projects(finder_params)
-    ProjectsFinder.new(params: finder_params, current_user: current_user)
-      .execute.includes(:route, namespace: :route)
+    ProjectsFinder
+      .new(params: finder_params, current_user: current_user)
+      .execute
+      .includes(:route, :creator, namespace: :route)
  end

  def load_events

--- a/changelogs/unreleased/eager-load-project-creators-for-project-dashboards.yml
+++ b/changelogs/unreleased/eager-load-project-creators-for-project-dashboards.yml
+---
+title: Eager load project creators for project dashboards
+merge_request:
+author: