Fix popen bug in `rake gitlab:satellites:create`

The Satellite#create method no longer sets the `$?` global variable. Instead, we can use the method return value to test if the satellite was created successfully

Fix popen bug in `rake gitlab:satellites:create`
bcfd9386 · Jacob Vosmaer · bfd44948 · bcfd9386 · bcfd9386
Commit bcfd9386 authored Apr 07, 2014 by Jacob Vosmaer
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

CHANGELOG CHANGELOG +1 -0

enable_automerge.rake lib/tasks/gitlab/enable_automerge.rake +2 -5

No files found.
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -8,6 +8,7 @@ v 6.8.0
  - Create branches via API (sponsored by O'Reilly Media)
  - Changed permission of gitlab-satellites directory not to be world accessible
  - Protected branch does not allow force push
+  - Fix popen bug in `rake gitlab:satellites:create`

 v 6.7.3
  - Fix the merge notification email not being sent (Pierre de La Morinerie)

--- a/lib/tasks/gitlab/enable_automerge.rake
+++ b/lib/tasks/gitlab/enable_automerge.rake
@@ -27,11 +27,8 @@ namespace :gitlab do
      if project.satellite.exists?
        puts "exists already".green
      else
-        puts ""
-        project.satellite.create
-
-        print "... "
-        if $?.success?
+        print "\n... "
+        if project.satellite.create
          puts "created".green
        else
          puts "error".red