BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
bafab35e
Unverified
Commit
bafab35e
authored
Feb 07, 2018
by
Matija Čupić
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use Prometheus counter instead of redis
parent
c00a17f6
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
14 deletions
+9
-14
check_gcp_project_billing_worker.rb
app/workers/check_gcp_project_billing_worker.rb
+6
-5
check_gcp_project_billing_worker_spec.rb
spec/workers/check_gcp_project_billing_worker_spec.rb
+3
-9
No files found.
app/workers/check_gcp_project_billing_worker.rb
View file @
bafab35e
...
...
@@ -54,8 +54,11 @@ class CheckGcpProjectBillingWorker
"gitlab:gcp:session:
#{
token_key
}
"
end
def
self
.
redis_billing_change_key
"gitlab:gcp:billing_enabled_changes"
def
billing_changed_counter
@billing_changed_counter
||=
Gitlab
::
Metrics
.
counter
(
:gcp_billing_change_count
,
"Counts the number of times a GCP project changed billing_enabled state from false to true"
)
end
def
try_obtain_lease_for
(
token
)
...
...
@@ -73,8 +76,6 @@ class CheckGcpProjectBillingWorker
def
update_billing_change_counter
(
previous_state
,
current_state
)
return
unless
previous_state
==
'false'
&&
current_state
Gitlab
::
Redis
::
SharedState
.
with
do
|
redis
|
redis
.
incr
(
self
.
class
.
redis_billing_change_key
)
end
billing_changed_counter
.
increment
end
end
spec/workers/check_gcp_project_billing_worker_spec.rb
View file @
bafab35e
...
...
@@ -87,9 +87,7 @@ describe CheckGcpProjectBillingWorker do
end
it
'does not increment the billing change counter'
do
Gitlab
::
Redis
::
SharedState
.
with
do
|
redis
|
expect
(
redis
).
not_to
receive
(
:incr
)
end
expect_any_instance_of
(
described_class
).
not_to
receive
(
:billing_changed_counter
)
subject
end
...
...
@@ -101,9 +99,7 @@ describe CheckGcpProjectBillingWorker do
end
it
'increments the billing change counter'
do
Gitlab
::
Redis
::
SharedState
.
with
do
|
redis
|
expect
(
redis
).
to
receive
(
:incr
)
end
expect_any_instance_of
(
described_class
).
to
receive_message_chain
(
:billing_changed_counter
,
:increment
)
subject
end
...
...
@@ -117,9 +113,7 @@ describe CheckGcpProjectBillingWorker do
end
it
'does not increment the billing change counter'
do
Gitlab
::
Redis
::
SharedState
.
with
do
|
redis
|
expect
(
redis
).
not_to
receive
(
:incr
)
end
expect_any_instance_of
(
described_class
).
not_to
receive
(
:billing_changed_counter
)
subject
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment