BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
b79e0088
Commit
b79e0088
authored
Dec 14, 2012
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Uncommented test observing comment event
parent
0ff46816
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
13 deletions
+19
-13
milestone.rb
app/models/milestone.rb
+5
-1
activity_observer.rb
app/observers/activity_observer.rb
+1
-1
activity_observer_spec.rb
spec/observers/activity_observer_spec.rb
+13
-11
No files found.
app/models/milestone.rb
View file @
b79e0088
...
...
@@ -14,7 +14,7 @@
class
Milestone
<
ActiveRecord
::
Base
attr_accessible
:title
,
:description
,
:due_date
,
:closed
,
:author_id_of_changes
attr_accessor
:author_id
,
:author_id
_of_changes
attr_accessor
:author_id_of_changes
belongs_to
:project
has_many
:issues
...
...
@@ -68,4 +68,8 @@ class Milestone < ActiveRecord::Base
def
open?
!
closed
end
def
author_id
author_id_of_changes
end
end
app/observers/activity_observer.rb
View file @
b79e0088
...
...
@@ -2,7 +2,7 @@ class ActivityObserver < ActiveRecord::Observer
observe
:issue
,
:merge_request
,
:note
,
:milestone
def
after_create
(
record
)
event_author_id
=
record
.
author_id
||
record
.
author_id_of_changes
event_author_id
=
record
.
author_id
# Skip status notes
if
record
.
kind_of?
(
Note
)
&&
record
.
note
.
include?
(
"_Status changed to "
)
...
...
spec/observers/activity_observer_spec.rb
View file @
b79e0088
...
...
@@ -34,15 +34,17 @@ describe ActivityObserver do
it
{
@event
.
target
.
should
==
@issue
}
end
#describe "Issue commented" do
#before do
#@issue = create(:issue, project: project)
#@note = create(:note, noteable: @issue, project: project)
#@event = Event.last
#end
#it_should_be_valid_event
#it { @event.action.should == Event::Commented }
#it { @event.target.should == @note }
#end
describe
"Issue commented"
do
before
do
Note
.
observers
.
enable
:activity_observer
do
@issue
=
create
(
:issue
,
project:
project
)
@note
=
create
(
:note
,
noteable:
@issue
,
project:
project
,
author:
@issue
.
author
)
@event
=
Event
.
last
end
end
it_should_be_valid_event
it
{
@event
.
action
.
should
==
Event
::
Commented
}
it
{
@event
.
target
.
should
==
@note
}
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment