Update invalid test application_settings_controller_spec.rb

There are 2 problems with this spec: 1. It checks for default visiblity level however there is not code in controller to handle such default. Same check can be performed on model directly. 2. It passes empty application_setting hash while controller requires application_setting not to be empty by using `require` with `permit` Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Update invalid test application_settings_controller_spec.rb
b6c6adfa · Dmitriy Zaporozhets · 6106cad9 · b6c6adfa
Unverified Commit b6c6adfa authored Apr 14, 2018 by Dmitriy Zaporozhets
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

application_settings_controller_spec.rb ...controllers/admin/application_settings_controller_spec.rb +2 -3

No files found.
--- a/spec/controllers/admin/application_settings_controller_spec.rb
+++ b/spec/controllers/admin/application_settings_controller_spec.rb
@@ -72,11 +72,10 @@ describe Admin::ApplicationSettingsController do
      expect(ApplicationSetting.current.restricted_visibility_levels).to eq([10, 20])
    end

-    it 'falls back to defaults when settings are omitted' do
-      put :update, application_setting: {}
+    it 'updates the restricted_visibility_levels when empty array is passed' do
+      put :update, application_setting: { restricted_visibility_levels: [] }

      expect(response).to redirect_to(admin_application_settings_path)
-      expect(ApplicationSetting.current.default_project_visibility).to eq(Gitlab::VisibilityLevel::PRIVATE)
      expect(ApplicationSetting.current.restricted_visibility_levels).to be_empty
    end
  end