Use 409 to indicate that interface might be outdated

Because invalid actions shouldn't be shown on the page.

Use 409 to indicate that interface might be outdated
b5c8d58a · Lin Jen-Shin · d08777b1 · b5c8d58a
Commit b5c8d58a authored Jun 28, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

runner_projects_controller.rb app/controllers/projects/runner_projects_controller.rb +2 -2

No files found.
--- a/app/controllers/projects/runner_projects_controller.rb
+++ b/app/controllers/projects/runner_projects_controller.rb
@@ -6,8 +6,8 @@ class Projects::RunnerProjectsController < Projects::ApplicationController
  def create
    @runner = Ci::Runner.find(params[:runner_project][:runner_id])

-    return head(403) if @runner.is_shared? || @runner.locked?
-    return head(403) unless current_user.ci_authorized_runners.include?(@runner)
+    return head(409) if @runner.is_shared? || @runner.locked?
+    return head(409) unless current_user.ci_authorized_runners.include?(@runner)

    path = runners_path(project)
    runner_project = @runner.assign_to(project, current_user)