BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
b5bc0fca
Commit
b5bc0fca
authored
Aug 14, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '36385-pipeline-graph-dropdown' into 'master'
Stops propagation for dropdown content in pipeline graph. Closes #36385 See merge request !13536
parents
cf55fb9b
f01e34df
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
0 deletions
+26
-0
dropdown_job_component.vue
...pts/pipelines/components/graph/dropdown_job_component.vue
+21
-0
36385-pipeline-graph-dropdown.yml
changelogs/unreleased/36385-pipeline-graph-dropdown.yml
+5
-0
No files found.
app/assets/javascripts/pipelines/components/graph/dropdown_job_component.vue
View file @
b5bc0fca
...
...
@@ -48,6 +48,27 @@
return
`
${
this
.
job
.
name
}
-
${
this
.
job
.
status
.
label
}
`
;
},
},
methods
:
{
/**
* When the user right clicks or cmd/ctrl + click in the job name
* the dropdown should not be closed and the link should open in another tab,
* so we stop propagation of the click event inside the dropdown.
*
* Since this component is rendered multiple times per page we need to guarantee we only
* target the click event of this component.
*/
stopDropdownClickPropagation
()
{
$
(
this
.
$el
.
querySelectorAll
(
'.js-grouped-pipeline-dropdown a.mini-pipeline-graph-dropdown-item'
))
.
on
(
'click'
,
(
e
)
=>
{
e
.
stopPropagation
();
});
},
},
mounted
()
{
this
.
stopDropdownClickPropagation
();
},
};
</
script
>
<
template
>
...
...
changelogs/unreleased/36385-pipeline-graph-dropdown.yml
0 → 100644
View file @
b5bc0fca
---
title
:
Prevents jobs dropdown from closing in pipeline graph
merge_request
:
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment