BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
b2041d1e
Commit
b2041d1e
authored
Apr 24, 2018
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'show-runners-description-on-jobs-page' into 'master'
Show Runner's description on job's page See merge request gitlab-org/gitlab-ce!17321
parents
f5524d55
d9325335
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
sidebar_details_block.vue
...ets/javascripts/jobs/components/sidebar_details_block.vue
+1
-1
show-runners-description-on-jobs-page.yml
...logs/unreleased/show-runners-description-on-jobs-page.yml
+5
-0
sidebar_details_block_spec.js
spec/javascripts/jobs/sidebar_details_block_spec.js
+1
-1
No files found.
app/assets/javascripts/jobs/components/sidebar_details_block.vue
View file @
b2041d1e
...
@@ -45,7 +45,7 @@ export default {
...
@@ -45,7 +45,7 @@ export default {
return
timeIntervalInWords
(
this
.
job
.
queued
);
return
timeIntervalInWords
(
this
.
job
.
queued
);
},
},
runnerId
()
{
runnerId
()
{
return
`
#
${
this
.
job
.
runner
.
id
}
`
;
return
`
${
this
.
job
.
runner
.
description
}
(#
${
this
.
job
.
runner
.
id
}
)
`
;
},
},
retryButtonClass
()
{
retryButtonClass
()
{
let
className
=
'js-retry-button pull-right btn btn-retry visible-md-block visible-lg-block'
;
let
className
=
'js-retry-button pull-right btn btn-retry visible-md-block visible-lg-block'
;
...
...
changelogs/unreleased/show-runners-description-on-jobs-page.yml
0 → 100644
View file @
b2041d1e
---
title
:
Show Runner's description on job's page
merge_request
:
17321
author
:
type
:
added
spec/javascripts/jobs/sidebar_details_block_spec.js
View file @
b2041d1e
...
@@ -102,7 +102,7 @@ describe('Sidebar details block', () => {
...
@@ -102,7 +102,7 @@ describe('Sidebar details block', () => {
});
});
it
(
'should render runner ID'
,
()
=>
{
it
(
'should render runner ID'
,
()
=>
{
expect
(
trimWhitespace
(
vm
.
$el
.
querySelector
(
'.js-job-runner'
))).
toEqual
(
'Runner:
#1
'
);
expect
(
trimWhitespace
(
vm
.
$el
.
querySelector
(
'.js-job-runner'
))).
toEqual
(
'Runner:
local ci runner (#1)
'
);
});
});
it
(
'should render timeout information'
,
()
=>
{
it
(
'should render timeout information'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment