BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
aea3569b
Commit
aea3569b
authored
Feb 05, 2018
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'sh-backport-groups-api-optimization' into 'master'
Backport /api/v4/groups N+1 query check from EE See merge request gitlab-org/gitlab-ce!16913
parents
679245e5
9cdde576
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
15 additions
and
0 deletions
+15
-0
groups_spec.rb
spec/requests/api/groups_spec.rb
+15
-0
No files found.
spec/requests/api/groups_spec.rb
View file @
aea3569b
...
...
@@ -30,6 +30,21 @@ describe API::Groups do
expect
(
json_response
)
.
to
satisfy_one
{
|
group
|
group
[
'name'
]
==
group1
.
name
}
end
it
'avoids N+1 queries'
do
# Establish baseline
get
api
(
"/groups"
,
admin
)
control
=
ActiveRecord
::
QueryRecorder
.
new
do
get
api
(
"/groups"
,
admin
)
end
create
(
:group
)
expect
do
get
api
(
"/groups"
,
admin
)
end
.
not_to
exceed_query_limit
(
control
)
end
end
context
"when authenticated as user"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment