Remove `projects` inclusion in `notes_with_associations` to skip some unnecessary queries

`notes_with_associations` are used for `participant` declarations, but `Participable` only really cares about the target entity project, and not the participants projects. `notes_with_associations` are also used in `Commit::has_been_reverted?` which employs the reference extractor of the commit, so no references to the notes projects are made there (`Mentionable::all_references` cares only about the `author` and other `attr_mentionable`). A paralel situation occurs on `Issue::referenced_merge_requests`.

Remove `projects` inclusion in `notes_with_associations` to skip some unnecessary queries
ad83c308 · Alejandro Rodríguez · 722211cd · ad83c308 · ad83c308 · ad83c308
Commit ad83c308 authored Jun 03, 2016 by Alejandro Rodríguez
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

commit.rb app/models/commit.rb +1 -1

issuable.rb app/models/concerns/issuable.rb +1 -1

snippet.rb app/models/snippet.rb +1 -1

No files found.
--- a/app/models/commit.rb
+++ b/app/models/commit.rb
@@ -198,7 +198,7 @@ class Commit
  end

  def notes_with_associations
-    notes.includes(:author, :project)
+    notes.includes(:author)
  end

  def method_missing(m, *args, &block)

--- a/app/models/concerns/issuable.rb
+++ b/app/models/concerns/issuable.rb
@@ -239,7 +239,7 @@ module Issuable
  end

  def notes_with_associations
-    notes.includes(:author, :project)
+    notes.includes(:author)
  end

  def updated_tasks

--- a/app/models/snippet.rb
+++ b/app/models/snippet.rb
@@ -102,7 +102,7 @@ class Snippet < ActiveRecord::Base
  end

  def notes_with_associations
-    notes.includes(:author, :project)
+    notes.includes(:author)
  end

  class << self