BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit a9f3f3c8 by Lin Jen-Shin
Options

Cleanup let a bit, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195683 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195692 another_artifacts was no longer used and then there's no point to put let in outer scope anymore.
parent 145da6b1
Showing with 6 additions and 10 deletions
spec/requests/api/builds_spec.rb
...@@ -213,17 +213,13 @@ describe API::API, api: true do ...@@ -213,17 +213,13 @@ describe API::API, api: true do
end end
context 'find proper build' do context 'find proper build' do
let(:another_artifacts) do
fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/gif')
end
let(:download_headers) do
{ 'Content-Transfer-Encoding' => 'binary',
'Content-Disposition' =>
"attachment; filename=#{build.artifacts_file.filename}" }
end
shared_examples 'a valid file' do shared_examples 'a valid file' do
let(:download_headers) do
{ 'Content-Transfer-Encoding' => 'binary',
'Content-Disposition' =>
"attachment; filename=#{build.artifacts_file.filename}" }
end
it { expect(response).to have_http_status(200) } it { expect(response).to have_http_status(200) }
it { expect(response.headers).to include(download_headers) } it { expect(response.headers).to include(download_headers) }
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment