BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
a8522050
Commit
a8522050
authored
Dec 20, 2016
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '25678-remove-user-build' into 'master'
Remove unnecessary method `build_user` from model `User` Closes #25678 See merge request !8162
parents
ca7e746b
3cc334ea
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
5 deletions
+5
-5
user.rb
app/models/user.rb
+0
-4
25678-remove-user-build.yml
changelogs/unreleased/25678-remove-user-build.yml
+4
-0
users.rb
lib/api/users.rb
+1
-1
No files found.
app/models/user.rb
View file @
a8522050
...
...
@@ -311,10 +311,6 @@ class User < ActiveRecord::Base
find_by
(
id:
Key
.
unscoped
.
select
(
:user_id
).
where
(
id:
key_id
))
end
def
build_user
(
attrs
=
{})
User
.
new
(
attrs
)
end
def
reference_prefix
'@'
end
...
...
changelogs/unreleased/25678-remove-user-build.yml
0 → 100644
View file @
a8522050
---
title
:
remove build_user
merge_request
:
8162
author
:
Arsenev Vladislav
lib/api/users.rb
View file @
a8522050
...
...
@@ -94,7 +94,7 @@ module API
identity_attrs
=
params
.
slice
(
:provider
,
:extern_uid
)
confirm
=
params
.
delete
(
:confirm
)
user
=
User
.
build_user
(
declared_params
(
include_missing:
false
))
user
=
User
.
new
(
declared_params
(
include_missing:
false
))
user
.
skip_confirmation!
unless
confirm
if
identity_attrs
.
any?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment