BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
a4eeb96d
Commit
a4eeb96d
authored
Apr 07, 2017
by
Stan Hu
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'clarify-mr-with-someone' into 'master'
Clarify what an MR needs to be 'with' a maintainer See merge request !10544
parents
e5a11687
043a0ec0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
5 deletions
+14
-5
PROCESS.md
PROCESS.md
+14
-5
No files found.
PROCESS.md
View file @
a4eeb96d
...
@@ -73,11 +73,20 @@ These types of merge requests need special consideration:
...
@@ -73,11 +73,20 @@ These types of merge requests need special consideration:
and a dedicated team with front-end, back-end, and UX.
and a dedicated team with front-end, back-end, and UX.
*
**Small features**
: any other feature request.
*
**Small features**
: any other feature request.
**Large features**
must be with a maintainer
**by the 1st**
. It's OK if they
**Large features**
must be with a maintainer
**by the 1st**
. This means that:
aren't completely done, but this allows the maintainer enough time to make the
decision about whether this can make it in before the freeze. If the maintainer
*
There is a merge request (even if it's WIP).
doesn't think it will make it, they should inform the developers working on it
*
The person (or people, if it needs a frontend and backend maintainer) who will
and the Product Manager responsible for the feature.
ultimately be responsible for merging this have been pinged on the MR.
It's OK if merge request isn't completely done, but this allows the maintainer
enough time to make the decision about whether this can make it in before the
freeze. If the maintainer doesn't think it will make it, they should inform the
developers working on it and the Product Manager responsible for the feature.
The maintainer can also choose to assign a reviewer to perform an initial
review, but this way the maintainer is unlikely to be surprised by receiving an
MR later in the cycle.
**Small features**
must be with a reviewer (not necessarily maintainer)
**
by the
**Small features**
must be with a reviewer (not necessarily maintainer)
**
by the
3rd
**
.
3rd
**
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment