Only load branch names for protected branch checks

When checking if a branch is protected we don't need all columns of every protected branch row, instead we only care about the names. By using "select" here we reduce the amount of data we need to send over the wire and load into memory.

Only load branch names for protected branch checks
a0527ab8 · Yorick Peterse · 52f5259a · a0527ab8 · a0527ab8 · a0527ab8
Unverified Commit a0527ab8 authored Nov 28, 2017 by Yorick Peterse
Showing with 11 additions and 2 deletions

protected_branch.rb app/models/protected_branch.rb +3 -1

protected_tag.rb app/models/protected_tag.rb +3 -1

protected-branches-names.yml changelogs/unreleased/protected-branches-names.yml +5 -0

No files found.
--- a/app/models/protected_branch.rb
+++ b/app/models/protected_branch.rb
@@ -10,7 +10,9 @@ class ProtectedBranch < ActiveRecord::Base
  def self.protected?(project, ref_name)
    return true if project.empty_repo? && default_branch_protected?

-    self.matching(ref_name, protected_refs: project.protected_branches).present?
+    refs = project.protected_branches.select(:name)
+
+    self.matching(ref_name, protected_refs: refs).present?
  end

  def self.default_branch_protected?

--- a/app/models/protected_tag.rb
+++ b/app/models/protected_tag.rb
@@ -5,6 +5,8 @@ class ProtectedTag < ActiveRecord::Base
  protected_ref_access_levels :create

  def self.protected?(project, ref_name)
-    self.matching(ref_name, protected_refs: project.protected_tags).present?
+    refs = project.protected_tags.select(:name)
+
+    self.matching(ref_name, protected_refs: refs).present?
  end
 end
--- a/changelogs/unreleased/protected-branches-names.yml
+++ b/changelogs/unreleased/protected-branches-names.yml
+---
+title: Only load branch names for protected branch checks
+merge_request:
+author:
+type: performance