BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
9f15028c
Commit
9f15028c
authored
Aug 11, 2017
by
James Edwards-Jones
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'fix-jenkins-error' into '9-4-stable-patch-5'
Fix displaying specific error message when Jenkins test fails See merge request !13510
parents
c7ad1f26
de6e029e
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
integration_settings_form.js
...ets/javascripts/integrations/integration_settings_form.js
+1
-1
integration_settings_form_spec.js
...avascripts/integrations/integration_settings_form_spec.js
+2
-2
No files found.
app/assets/javascripts/integrations/integration_settings_form.js
View file @
9f15028c
...
...
@@ -102,7 +102,7 @@ export default class IntegrationSettingsForm {
})
.
done
((
res
)
=>
{
if
(
res
.
error
)
{
new
Flash
(
res
.
message
,
null
,
null
,
{
new
Flash
(
`
${
res
.
message
}
${
res
.
service_response
}
`
,
null
,
null
,
{
title
:
'Save anyway'
,
clickHandler
:
(
e
)
=>
{
e
.
preventDefault
();
...
...
spec/javascripts/integrations/integration_settings_form_spec.js
View file @
9f15028c
...
...
@@ -135,10 +135,10 @@ describe('IntegrationSettingsForm', () => {
integrationSettingsForm
.
testSettings
(
formData
);
deferred
.
resolve
({
error
:
true
,
message
:
errorMessage
});
deferred
.
resolve
({
error
:
true
,
message
:
errorMessage
,
service_response
:
'some error'
});
const
$flashContainer
=
$
(
'.flash-container'
);
expect
(
$flashContainer
.
find
(
'.flash-text'
).
text
()).
toEqual
(
errorMessage
);
expect
(
$flashContainer
.
find
(
'.flash-text'
).
text
()).
toEqual
(
'Test failed. some error'
);
expect
(
$flashContainer
.
find
(
'.flash-action'
)).
toBeDefined
();
expect
(
$flashContainer
.
find
(
'.flash-action'
).
text
()).
toEqual
(
'Save anyway'
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment