BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
9ec58d8a
Commit
9ec58d8a
authored
Apr 12, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add aria to icon
parent
18188a53
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
0 deletions
+9
-0
icons_helper.rb
app/helpers/icons_helper.rb
+5
-0
add-aria-to-icon.yml
changelogs/unreleased/add-aria-to-icon.yml
+4
-0
No files found.
app/helpers/icons_helper.rb
View file @
9ec58d8a
...
...
@@ -7,6 +7,11 @@ module IconsHelper
# font-awesome-rails gem, but should we ever use a different icon pack in the
# future we won't have to change hundreds of method calls.
def
icon
(
names
,
options
=
{})
if
!
options
[
'aria-hidden'
]
and
!
options
[
'aria-label'
]
# Add `aria-hidden` if there are no aria's set
options
[
'aria-hidden'
]
=
true
end
options
.
include?
(
:base
)
?
fa_stacked_icon
(
names
,
options
)
:
fa_icon
(
names
,
options
)
end
...
...
changelogs/unreleased/add-aria-to-icon.yml
0 → 100644
View file @
9ec58d8a
---
title
:
Update icon() to automatically include aria-hidden if aria is not found
merge_request
:
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment