Merge branch 'dropdown-enter-select' into 'master'

Fixed issue with enter key selecting wrong option in dropdown If you search for a label and press enter the dropdown will select the last element rather than the first. This is because the currentIndex is -1 rather than 0 ![labels](/uploads/eb29924109947fd63fea32e21471f05a/labels.gif) Closes #17630 See merge request !4210

Merge branch 'dropdown-enter-select' into 'master'
98b1daf3 · Jacob Schatz · 9aab0f09 · 9f60a2ed · 98b1daf3
Commit 98b1daf3 authored May 21, 2016 by Jacob Schatz
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

gl_dropdown.js.coffee app/assets/javascripts/gl_dropdown.js.coffee +1 -1

No files found.
--- a/app/assets/javascripts/gl_dropdown.js.coffee
+++ b/app/assets/javascripts/gl_dropdown.js.coffee
@@ -512,7 +512,7 @@ class GitLabDropdown
        return false

      if currentKeyCode is 13
-        @selectRowAtIndex currentIndex
+        @selectRowAtIndex if currentIndex < 0 then 0 else currentIndex

  removeArrayKeyEvent: ->
    $('body').off 'keydown'