Fix missing WHERE clause in 20171106135924_issues_milestone_id_foreign_key migration

If milestone_id is NULL, we shouldn't need to update it to be NULL again. This was causing us to touch almost all rows in the issues table for no good reason. Closes https://gitlab.com/gitlab-com/infrastructure/issues/3416

Fix missing WHERE clause in 20171106135924_issues_milestone_id_foreign_key migration
9611a410 · Stan Hu · f7a9ced2 · 9611a410
Commit 9611a410 authored Dec 18, 2017 by Stan Hu
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

20171106135924_issues_milestone_id_foreign_key.rb db/migrate/20171106135924_issues_milestone_id_foreign_key.rb +1 -0

No files found.
--- a/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb
+++ b/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb
@@ -16,6 +16,7 @@ class IssuesMilestoneIdForeignKey < ActiveRecord::Migration

    def self.with_orphaned_milestones
      where('NOT EXISTS (SELECT true FROM milestones WHERE milestones.id = issues.milestone_id)')
+        .where('milestone_id IS NOT NULL')
    end
  end