BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
94cc685f
Commit
94cc685f
authored
Jan 22, 2017
by
Jacob Schatz
Committed by
James Lopez
Jan 24, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Merge branch 'merge-dropdown-this-context' into 'master'
Fixed bug with merge immediately button not working See merge request !8696
parent
b697b783
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
46 additions
and
1 deletion
+46
-1
ci_bundle.js.es6
app/assets/javascripts/merge_request_widget/ci_bundle.js.es6
+1
-1
merge-dropdown-this-context.yml
changelogs/unreleased/merge-dropdown-this-context.yml
+4
-0
merge_immediately_with_pipeline_spec.rb
...es/merge_requests/merge_immediately_with_pipeline_spec.rb
+41
-0
No files found.
app/assets/javascripts/merge_request_widget/ci_bundle.js.es6
View file @
94cc685f
...
...
@@ -30,7 +30,7 @@
.off('click', '.js-merge-dropdown a')
.on('click', '.js-merge-dropdown a', (e) => {
e.preventDefault();
$(
this
).closest('form').submit();
$(
e.target
).closest('form').submit();
});
if ($('.rebase-in-progress').length) {
merge_request_widget.rebaseInProgress();
...
...
changelogs/unreleased/merge-dropdown-this-context.yml
0 → 100644
View file @
94cc685f
---
title
:
Fixed bug where links in merge dropdown wouldn't work
merge_request
:
author
:
spec/features/merge_requests/merge_immediately_with_pipeline_spec.rb
0 → 100644
View file @
94cc685f
require
'spec_helper'
feature
'Merge immediately'
,
:feature
,
:js
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
,
:public
)
}
let
(
:merge_request
)
do
create
(
:merge_request_with_diffs
,
source_project:
project
,
author:
user
,
title:
'Bug NS-04'
)
end
let
(
:pipeline
)
do
create
(
:ci_pipeline
,
project:
project
,
sha:
merge_request
.
diff_head_sha
,
ref:
merge_request
.
source_branch
)
end
before
{
project
.
team
<<
[
user
,
:master
]
}
context
'when there is active pipeline for merge request'
do
background
do
create
(
:ci_build
,
pipeline:
pipeline
)
end
before
do
login_as
user
visit
namespace_project_merge_request_path
(
merge_request
.
project
.
namespace
,
merge_request
.
project
,
merge_request
)
end
it
'enables merge immediately'
do
page
.
within
'.mr-widget-body'
do
find
(
'.dropdown-toggle'
).
click
click_link
'Merge Immediately'
expect
(
find
(
'.js-merge-button'
)).
to
have_content
(
'Merge in progress'
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment