BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
942fe5fe
Commit
942fe5fe
authored
May 24, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'fl-loading-icon' into 'master'
Show loading icon only when making the request See merge request gitlab-org/gitlab-ce!19116
parents
e97a8743
25aec20f
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
22 additions
and
4 deletions
+22
-4
pipelines_table.vue
...sets/javascripts/pipelines/components/pipelines_table.vue
+3
-0
pipelines_table_row.vue
.../javascripts/pipelines/components/pipelines_table_row.vue
+9
-3
pipelines_table_row_spec.js
spec/javascripts/pipelines/pipelines_table_row_spec.js
+10
-1
No files found.
app/assets/javascripts/pipelines/components/pipelines_table.vue
View file @
942fe5fe
...
...
@@ -37,6 +37,7 @@
return
{
pipelineId
:
''
,
endpoint
:
''
,
cancelingPipeline
:
null
,
};
},
computed
:
{
...
...
@@ -64,6 +65,7 @@
},
onSubmit
()
{
eventHub
.
$emit
(
'postAction'
,
this
.
endpoint
);
this
.
cancelingPipeline
=
this
.
pipelineId
;
},
},
};
...
...
@@ -106,6 +108,7 @@
:update-graph-dropdown=
"updateGraphDropdown"
:auto-devops-help-path=
"autoDevopsHelpPath"
:view-type=
"viewType"
:canceling-pipeline=
"cancelingPipeline"
/>
<modal
...
...
app/assets/javascripts/pipelines/components/pipelines_table_row.vue
View file @
942fe5fe
...
...
@@ -46,12 +46,16 @@
type
:
String
,
required
:
true
,
},
cancelingPipeline
:
{
type
:
String
,
required
:
false
,
default
:
null
,
},
},
pipelinesTable
:
PIPELINES_TABLE
,
data
()
{
return
{
isRetrying
:
false
,
isCancelling
:
false
,
};
},
computed
:
{
...
...
@@ -227,12 +231,14 @@
isChildView
()
{
return
this
.
viewType
===
'child'
;
},
isCancelling
()
{
return
this
.
cancelingPipeline
===
this
.
pipeline
.
id
;
},
},
methods
:
{
handleCancelClick
()
{
this
.
isCancelling
=
true
;
eventHub
.
$emit
(
'openConfirmationModal'
,
{
pipelineId
:
this
.
pipeline
.
id
,
endpoint
:
this
.
pipeline
.
cancel_path
,
...
...
spec/javascripts/pipelines/pipelines_table_row_spec.js
View file @
942fe5fe
...
...
@@ -182,7 +182,16 @@ describe('Pipelines Table Row', () => {
});
component
.
$el
.
querySelector
(
'.js-pipelines-cancel-button'
).
click
();
expect
(
component
.
isCancelling
).
toEqual
(
true
);
});
it
(
'renders a loading icon when `cancelingPipeline` matches pipeline id'
,
done
=>
{
component
.
cancelingPipeline
=
pipeline
.
id
;
component
.
$nextTick
()
.
then
(()
=>
{
expect
(
component
.
isCancelling
).
toEqual
(
true
);
})
.
then
(
done
)
.
catch
(
done
.
fail
);
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment