Merge branch '28857-followup-fix-pages-test' into 'master'

Fix a test that is going to break, that has not broken yet See merge request gitlab-org/gitlab-ce!17966

Merge branch '28857-followup-fix-pages-test' into 'master'
93e216e6 · Robert Speicher · d6abee51 · 1f04248c · 93e216e6
Commit 93e216e6 authored Mar 23, 2018 by Robert Speicher
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

pages_spec.rb spec/features/projects/pages_spec.rb +4 -3

No files found.
--- a/spec/features/projects/pages_spec.rb
+++ b/spec/features/projects/pages_spec.rb
@@ -244,10 +244,11 @@ feature 'Pages' do
    end

    context 'setting could not be updated' do
+      let(:service) { instance_double('Projects::UpdateService') }
+
      before do
-        allow_any_instance_of(Projects::UpdateService)
-          .to receive(:execute)
-          .and_return(status: :error)
+        allow(Projects::UpdateService).to receive(:new).and_return(service)
+        allow(service).to receive(:execute).and_return(status: :error)
      end

      scenario 'tries to change the setting' do