BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
9280fd4a
Commit
9280fd4a
authored
Mar 18, 2016
by
Jacob Schatz
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'fix-mr-close-button' into 'master'
Fixes issue with close button not working on MR Closes #14383 See merge request !3295
parents
8dfa0a76
195ef985
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
2 deletions
+10
-2
notes.js.coffee
app/assets/javascripts/notes.js.coffee
+2
-2
merge_requests.feature
features/project/merge_requests.feature
+8
-0
No files found.
app/assets/javascripts/notes.js.coffee
View file @
9280fd4a
...
@@ -627,10 +627,10 @@ class @Notes
...
@@ -627,10 +627,10 @@ class @Notes
if
closebtn
.
text
()
isnt
closetext
if
closebtn
.
text
()
isnt
closetext
closebtn
.
text
(
closetext
)
closebtn
.
text
(
closetext
)
if
reopenbtn
.
is
(
'
:not(.btn-comment-and-reopen)
'
)
if
reopenbtn
.
is
(
'
.btn-comment-and-reopen
'
)
reopenbtn
.
removeClass
(
'btn-comment-and-reopen'
)
reopenbtn
.
removeClass
(
'btn-comment-and-reopen'
)
if
closebtn
.
is
(
'
:not(.btn-comment-and-close)
'
)
if
closebtn
.
is
(
'
.btn-comment-and-close
'
)
closebtn
.
removeClass
(
'btn-comment-and-close'
)
closebtn
.
removeClass
(
'btn-comment-and-close'
)
if
discardbtn
.
is
(
':visible'
)
if
discardbtn
.
is
(
':visible'
)
...
...
features/project/merge_requests.feature
View file @
9280fd4a
...
@@ -325,3 +325,11 @@ Feature: Project Merge Requests
...
@@ -325,3 +325,11 @@ Feature: Project Merge Requests
When
I click the
"Target branch"
dropdown
When
I click the
"Target branch"
dropdown
And
I select a new target branch
And
I select a new target branch
Then
I should see new target branch changes
Then
I should see new target branch changes
@javascript
Scenario
:
I
can close merge request after commenting
Given
I visit merge request page
"Bug NS-04"
And
I leave a comment like
"XML attached"
Then
I should see comment
"XML attached"
And
I click link
"Close"
Then
I should see closed merge request
"Bug NS-04"
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment