BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
8f85bd57
Commit
8f85bd57
authored
Nov 08, 2016
by
Sean McGivern
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'todos-filter-empty-state' into 'master'
Fixed todos empty state when filtering Closes #24127 See merge request !7334
parents
034e8593
dd93079a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
9 deletions
+17
-9
todos_helper.rb
app/helpers/todos_helper.rb
+4
-0
index.html.haml
app/views/dashboard/todos/index.html.haml
+13
-9
No files found.
app/helpers/todos_helper.rb
View file @
8f85bd57
...
...
@@ -61,6 +61,10 @@ module TodosHelper
}
end
def
todos_filter_empty?
todos_filter_params
.
values
.
none?
end
def
todos_filter_path
(
options
=
{})
without
=
options
.
delete
(
:without
)
...
...
app/views/dashboard/todos/index.html.haml
View file @
8f85bd57
...
...
@@ -82,15 +82,19 @@
-
elsif
current_user
.
todos
.
any?
.todos-all-done
=
render
"shared/empty_states/todos_all_done.svg"
%h4
.text-center
Good job! Looks like you don't have any todos left.
%p
.text-center
Are you looking for things to do? Take a look at
=
succeed
","
do
=
link_to
"the opened issues"
,
issues_dashboard_path
contribute to
=
link_to
"merge requests"
,
merge_requests_dashboard_path
or mention someone in a comment to assign a new todo automatically.
-
if
todos_filter_empty?
%h4
.text-center
Good job! Looks like you don't have any todos left.
%p
.text-center
Are you looking for things to do? Take a look at
=
succeed
","
do
=
link_to
"the opened issues"
,
issues_dashboard_path
contribute to
=
link_to
"merge requests"
,
merge_requests_dashboard_path
or mention someone in a comment to assign a new todo automatically.
-
else
%h4
.text-center
There are no todos to show.
-
else
.todos-empty
.todos-empty-hero
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment