Do not let NGINX buffer Git HTTP requests

Before this change NGINX would convert a chunked HTTP POST (e.g. git push) into a HTTP 1.0 single large POST. This creates an unnecessary delay, and it creates unnecessary memory pressure on gitlab-git-http-server. For the response ('proxy_buffering') I am less sure that NGINX 's buffering behavior is harmful, but it still makes more sense to me not to interfere with gitlab-git-http-server (and the Golang net/http server).

Do not let NGINX buffer Git HTTP requests
8d59b1ac · Jacob Vosmaer · 0fbd6244 · 8d59b1ac · 8d59b1ac
Commit 8d59b1ac authored Sep 07, 2015 by Jacob Vosmaer
Hide whitespace changes
Inline Side-by-side

Showing with 14 additions and 0 deletions

gitlab lib/support/nginx/gitlab +7 -0

gitlab-ssl lib/support/nginx/gitlab-ssl +7 -0

No files found.
--- a/lib/support/nginx/gitlab
+++ b/lib/support/nginx/gitlab
@@ -124,6 +124,13 @@ server {
    proxy_connect_timeout   300;
    proxy_redirect          off;

+    # Do not buffer Git HTTP responses
+    proxy_buffering off;
+
+    # Pass chunked request bodies to gitlab-git-http-server as-is
+    proxy_request_buffering off;
+    proxy_http_version 1.1;
+
    proxy_set_header    Host                $http_host;
    proxy_set_header    X-Real-IP           $remote_addr;
    proxy_set_header    X-Forwarded-For     $proxy_add_x_forwarded_for;

--- a/lib/support/nginx/gitlab-ssl
+++ b/lib/support/nginx/gitlab-ssl
@@ -171,6 +171,13 @@ server {
    proxy_connect_timeout   300;
    proxy_redirect          off;

+    # Do not buffer Git HTTP responses
+    proxy_buffering off;
+
+    # Pass chunked request bodies to gitlab-git-http-server as-is
+    proxy_request_buffering off;
+    proxy_http_version 1.1;
+
    proxy_set_header    Host                $http_host;
    proxy_set_header    X-Real-IP           $remote_addr;
    proxy_set_header    X-Forwarded-Ssl     on;