Changes when loading indicator is added to dropdown

Previously it was added when you started typing. But there is actually a delay before sending any requests which meant the loading icon was visible but it wasn't actually loading anything

Changes when loading indicator is added to dropdown
8cbf27af · Phil Hughes · dc303fe2 · 8cbf27af
Commit 8cbf27af authored Feb 17, 2017 by Phil Hughes
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

gl_dropdown.js app/assets/javascripts/gl_dropdown.js +2 -1

No files found.
--- a/app/assets/javascripts/gl_dropdown.js
+++ b/app/assets/javascripts/gl_dropdown.js
@@ -47,9 +47,10 @@
          }
          // Only filter asynchronously only if option remote is set
          if (this.options.remote) {
-            $inputContainer.parent().addClass('is-loading');
            clearTimeout(timeout);
            return timeout = setTimeout(function() {
+              $inputContainer.parent().addClass('is-loading');
+              
              return this.options.query(this.input.val(), function(data) {
                $inputContainer.parent().removeClass('is-loading');
                return this.options.callback(data);