Avoid a TypeError when initializing MergeRequest JS class with no arg

Without this sane default you would get the following error when you tried to instantiate a new MergeRequest object with no argument (i.e. `new MergeRequest();`): TypeError: undefined is not an object (evaluating 'this.opts.action') Signed-off-by: Rémy Coutable <remy@rymai.me>

Avoid a TypeError when initializing MergeRequest JS class with no arg
8aed815b · Rémy Coutable · d8563bd6 · 8aed815b · 8aed815b
Unverified Commit 8aed815b authored Jun 15, 2016 by Rémy Coutable
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

merge_request.js.coffee app/assets/javascripts/merge_request.js.coffee +1 -1

merge_request_spec.js.coffee spec/javascripts/merge_request_spec.js.coffee +1 -1

No files found.
--- a/app/assets/javascripts/merge_request.js.coffee
+++ b/app/assets/javascripts/merge_request.js.coffee
@@ -9,7 +9,7 @@ class @MergeRequest
  # Options:
  #   action - String, current controller action
  #
-  constructor: (@opts) ->
+  constructor: (@opts = {}) ->
    this.$el = $('.merge-request')

    this.$('.show-all-commits').on 'click', =>

--- a/spec/javascripts/merge_request_spec.js.coffee
+++ b/spec/javascripts/merge_request_spec.js.coffee
@@ -6,7 +6,7 @@ describe 'MergeRequest', ->

    beforeEach ->
      fixture.load('merge_requests_show.html')
-      @merge = new MergeRequest({})
+      @merge = new MergeRequest()

    it 'modifies the Markdown field', ->
      spyOn(jQuery, 'ajax').and.stub()