BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
8a167554
Commit
8a167554
authored
Aug 07, 2017
by
http://jneen.net/
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
reduce iterations by keeping a count of remaining enablers
rather than iterating the whole remaining step set with .all?(&:prevent?)
parent
bc648ae5
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
runner.rb
lib/declarative_policy/runner.rb
+4
-1
No files found.
lib/declarative_policy/runner.rb
View file @
8a167554
...
...
@@ -141,13 +141,14 @@ module DeclarativePolicy
end
steps
=
Set
.
new
(
@steps
)
remaining_enablers
=
steps
.
count
{
|
s
|
s
.
enable?
}
loop
do
return
if
steps
.
empty?
# if the permission hasn't yet been enabled and we only have
# prevent steps left, we short-circuit the state here
@state
.
prevent!
if
!
@state
.
enabled?
&&
steps
.
all?
(
&
:prevent?
)
@state
.
prevent!
if
!
@state
.
enabled?
&&
remaining_enablers
==
0
lowest_score
=
Float
::
INFINITY
next_step
=
nil
...
...
@@ -162,6 +163,8 @@ module DeclarativePolicy
steps
.
delete
(
next_step
)
remaining_enablers
-=
1
if
next_step
.
enable?
yield
next_step
,
lowest_score
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment