BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
89c3c88e
Commit
89c3c88e
authored
Jan 17, 2018
by
Jacob Schatz
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add confirm when navigating away from page with tests.
parent
50a64953
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
49 additions
and
0 deletions
+49
-0
app.vue
app/assets/javascripts/issue_show/components/app.vue
+16
-0
app_spec.js
spec/javascripts/issue_show/components/app_spec.js
+33
-0
No files found.
app/assets/javascripts/issue_show/components/app.vue
View file @
89c3c88e
...
...
@@ -152,6 +152,12 @@
hasUpdated
()
{
return
!!
this
.
state
.
updatedAt
;
},
issueChanged
()
{
return
this
.
initialDescriptionText
!==
this
.
store
.
formState
.
description
||
this
.
initialTitleText
!==
this
.
store
.
formState
.
title
;
},
},
created
()
{
this
.
service
=
new
Service
(
this
.
endpoint
);
...
...
@@ -176,6 +182,8 @@
}
});
window
.
addEventListener
(
'beforeunload'
,
this
.
handleBeforeUnloadEvent
);
eventHub
.
$on
(
'delete.issuable'
,
this
.
deleteIssuable
);
eventHub
.
$on
(
'update.issuable'
,
this
.
updateIssuable
);
eventHub
.
$on
(
'close.form'
,
this
.
closeForm
);
...
...
@@ -188,6 +196,14 @@
eventHub
.
$off
(
'open.form'
,
this
.
openForm
);
},
methods
:
{
handleBeforeUnloadEvent
(
e
)
{
const
event
=
e
;
if
(
this
.
showForm
&&
this
.
issueChanged
)
{
event
.
returnValue
=
'Are you sure you want to lose your issue information?'
;
}
return
undefined
;
},
openForm
()
{
if
(
!
this
.
showForm
)
{
this
.
showForm
=
true
;
...
...
spec/javascripts/issue_show/components/app_spec.js
View file @
89c3c88e
...
...
@@ -218,6 +218,39 @@ describe('Issuable output', () => {
});
});
describe
(
'shows dialog when issue has unsaved changed'
,
()
=>
{
it
(
'confirms on title change'
,
(
done
)
=>
{
vm
.
showForm
=
true
;
vm
.
state
.
titleText
=
'title has changed'
;
const
e
=
{
returnValue
:
null
};
vm
.
handleBeforeUnloadEvent
(
e
);
Vue
.
nextTick
(()
=>
{
expect
(
e
.
returnValue
).
not
.
toBeNull
();
done
();
});
});
it
(
'confirms on description change'
,
(
done
)
=>
{
vm
.
showForm
=
true
;
vm
.
state
.
descriptionText
=
'description has changed'
;
const
e
=
{
returnValue
:
null
};
vm
.
handleBeforeUnloadEvent
(
e
);
Vue
.
nextTick
(()
=>
{
expect
(
e
.
returnValue
).
not
.
toBeNull
();
done
();
});
});
it
(
'does nothing when nothing has changed'
,
(
done
)
=>
{
const
e
=
{
returnValue
:
null
};
vm
.
handleBeforeUnloadEvent
(
e
);
Vue
.
nextTick
(()
=>
{
expect
(
e
.
returnValue
).
toBeNull
();
done
();
});
});
});
describe
(
'error when updating'
,
()
=>
{
beforeEach
(()
=>
{
spyOn
(
window
,
'Flash'
).
and
.
callThrough
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment