Fix boolean casting for nil value

`nil` value is not included in `ActiveModel::Type::Boolean::FALSE_VALUES` which caused that in Rails 5 the boolean_accessor converted `nil` to `true` instead of `false`.

Fix boolean casting for nil value
884fbf1d · Jan Provaznik · c5adf04c · 884fbf1d
Commit 884fbf1d authored May 29, 2018 by Jan Provaznik
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

service.rb app/models/service.rb +3 -2

No files found.
--- a/app/models/service.rb
+++ b/app/models/service.rb
@@ -206,10 +206,11 @@ class Service < ActiveRecord::Base
    args.each do |arg|
      class_eval %{
        def #{arg}?
+          # '!!' is used because nil or empty string is converted to nil
          if Gitlab.rails5?
-            !ActiveModel::Type::Boolean::FALSE_VALUES.include?(#{arg})
+            !!ActiveRecord::Type::Boolean.new.cast(#{arg})
          else
-            ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(#{arg})
+            !!ActiveRecord::Type::Boolean.new.type_cast_from_database(#{arg})
          end
        end
      }