'created_at DESC' is performed twice

If you are already sorting in descending order in the created_at, it is run twice when you run the .recent. It has passed in the string 'created_at DESC'. Ruby on Rails is directly given to the SQL. It is a slow query in MySQL.

'created_at DESC' is performed twice
87ac5900 · catatsuy · 7c42aaa5 · 87ac5900
Commit 87ac5900 authored Jun 16, 2015 by catatsuy
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

event.rb app/models/event.rb +1 -1

No files found.
--- a/app/models/event.rb
+++ b/app/models/event.rb
@@ -44,7 +44,7 @@ class Event < ActiveRecord::Base
  after_create :reset_project_activity

  # Scopes
-  scope :recent, -> { order("created_at DESC") }
+  scope :recent, -> { order(created_at: :desc) }
  scope :code_push, -> { where(action: PUSHED) }
  scope :in_projects, ->(project_ids) { where(project_id: project_ids).recent }
  scope :with_associations, -> { includes(project: :namespace) }