Fix HTTP push to public repos

When doing an HTTP push, git (as of v1.7.9) first do an info/refs request, and only if this request requires authentication it asks the user for its password and authenticates further requests. The initial request normally clears without auth on public repos as it doesn't update any ref. This patch forces every git-receive-pack requests to provide authentication.

Fix HTTP push to public repos
843548cc · Thomas Guyot-Sionnest · 23d180f5 · 843548cc
Commit 843548cc authored Dec 04, 2013 by Thomas Guyot-Sionnest
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

grack_auth.rb lib/gitlab/backend/grack_auth.rb +3 -0

No files found.
--- a/lib/gitlab/backend/grack_auth.rb
+++ b/lib/gitlab/backend/grack_auth.rb
@@ -92,6 +92,9 @@ module Grack
          return false unless can?(user, action, project)
        end

+        # Never let git-receive-pack trough unauthenticated; it's
+        # harmless but git < 1.8 doesn't like it
+        return false if user.nil?
        true
      else
        false