BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
82576518
Commit
82576518
authored
May 15, 2018
by
Andreas Brandl
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Migration to add/drop primary key constraints for composite keys.
Closes #43706.
parent
a0c79f9d
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
78 additions
and
0 deletions
+78
-0
composite_primary_keys.rb
db/optional_migrations/composite_primary_keys.rb
+63
-0
composite_primary_keys.rake
lib/tasks/migrate/composite_primary_keys.rake
+15
-0
No files found.
db/optional_migrations/composite_primary_keys.rb
0 → 100644
View file @
82576518
# This migration adds a primary key constraint to tables
# that only have a composite unique key.
#
# This is not strictly relevant to Rails (v4 does not
# support composite primary keys). However this becomes
# useful for e.g. PostgreSQL's logical replication (pglogical)
# which requires all tables to have a primary key constraint.
#
# In that sense, the migration is optional and not strictly needed.
class
CompositePrimaryKeysMigration
<
ActiveRecord
::
Migration
include
Gitlab
::
Database
::
MigrationHelpers
DOWNTIME
=
false
Index
=
Struct
.
new
(
:table
,
:name
,
:columns
)
TABLES
=
[
Index
.
new
(
:issue_assignees
,
'index_issue_assignees_on_issue_id_and_user_id'
,
%i(issue_id user_id)
),
Index
.
new
(
:user_interacted_projects
,
'index_user_interacted_projects_on_project_id_and_user_id'
,
%i(project_id user_id)
),
Index
.
new
(
:merge_request_diff_files
,
'index_merge_request_diff_files_on_mr_diff_id_and_order'
,
%i(merge_request_diff_id relative_order)
),
Index
.
new
(
:merge_request_diff_commits
,
'index_merge_request_diff_commits_on_mr_diff_id_and_order'
,
%i(merge_request_diff_id relative_order)
),
Index
.
new
(
:project_authorizations
,
'index_project_authorizations_on_user_id_project_id_access_level'
,
%i(user_id project_id access_level)
),
Index
.
new
(
:push_event_payloads
,
'index_push_event_payloads_on_event_id'
,
%i(event_id)
),
Index
.
new
(
:schema_migrations
,
'unique_schema_migrations'
,
%(version)
),
]
disable_ddl_transaction!
def
up
return
unless
Gitlab
::
Database
.
postgresql?
disable_statement_timeout
TABLES
.
each
do
|
index
|
add_primary_key
(
index
)
end
end
def
down
return
unless
Gitlab
::
Database
.
postgresql?
disable_statement_timeout
TABLES
.
each
do
|
index
|
remove_primary_key
(
index
)
end
end
private
def
add_primary_key
(
index
)
execute
"ALTER TABLE
#{
index
.
table
}
ADD PRIMARY KEY USING INDEX
#{
index
.
name
}
"
end
def
remove_primary_key
(
index
)
temp_index_name
=
"
#{
index
.
name
[
0
..
58
]
}
_old"
rename_index
index
.
table
,
index
.
name
,
temp_index_name
if
index_exists_by_name?
(
index
.
table
,
index
.
name
)
# re-create unique key index
add_concurrent_index
index
.
table
,
index
.
columns
,
unique:
true
,
name:
index
.
name
# This also drops the `temp_index_name` as this is owned by the constraint
execute
"ALTER TABLE
#{
index
.
table
}
DROP CONSTRAINT IF EXISTS
#{
temp_index_name
}
"
end
end
lib/tasks/migrate/composite_primary_keys.rake
0 → 100644
View file @
82576518
namespace
:gitlab
do
namespace
:db
do
desc
'GitLab | Adds primary keys to tables that only have composite unique keys'
task
composite_primary_keys_add: :environment
do
require
Rails
.
root
.
join
(
'db/optional_migrations/composite_primary_keys'
)
CompositePrimaryKeysMigration
.
new
.
up
end
desc
'GitLab | Removes previously added composite primary keys'
task
composite_primary_keys_drop: :environment
do
require
Rails
.
root
.
join
(
'db/optional_migrations/composite_primary_keys'
)
CompositePrimaryKeysMigration
.
new
.
down
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment