BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
78b044a1
Commit
78b044a1
authored
Jan 08, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'issue-40190' into 'master'
Fix slash commands dropdown description See merge request gitlab-org/gitlab-ce!16125
parents
82e2d90b
f07727d9
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
3 deletions
+20
-3
gfm_auto_complete.js
app/assets/javascripts/gfm_auto_complete.js
+3
-3
markdown_area.scss
app/assets/stylesheets/framework/markdown_area.scss
+12
-0
40190-fix-slash-commands-dropdown-description-mis-alignement-on-firefox.yml
...mmands-dropdown-description-mis-alignement-on-firefox.yml
+5
-0
No files found.
app/assets/javascripts/gfm_auto_complete.js
View file @
78b044a1
...
@@ -57,12 +57,12 @@ class GfmAutoComplete {
...
@@ -57,12 +57,12 @@ class GfmAutoComplete {
displayTpl
(
value
)
{
displayTpl
(
value
)
{
if
(
GfmAutoComplete
.
isLoading
(
value
))
return
GfmAutoComplete
.
Loading
.
template
;
if
(
GfmAutoComplete
.
isLoading
(
value
))
return
GfmAutoComplete
.
Loading
.
template
;
// eslint-disable-next-line no-template-curly-in-string
// eslint-disable-next-line no-template-curly-in-string
let
tpl
=
'<li>
/${name}
'
;
let
tpl
=
'<li>
<span class="name">/${name}</span>
'
;
if
(
value
.
aliases
.
length
>
0
)
{
if
(
value
.
aliases
.
length
>
0
)
{
tpl
+=
' <small>(or /<%- aliases.join(", /") %>)</small>'
;
tpl
+=
' <small
class="aliases"
>(or /<%- aliases.join(", /") %>)</small>'
;
}
}
if
(
value
.
params
.
length
>
0
)
{
if
(
value
.
params
.
length
>
0
)
{
tpl
+=
' <small><%- params.join(" ") %></small>'
;
tpl
+=
' <small
class="params"
><%- params.join(" ") %></small>'
;
}
}
if
(
value
.
description
!==
''
)
{
if
(
value
.
description
!==
''
)
{
tpl
+=
'<small class="description"><i><%- description %></i></small>'
;
tpl
+=
'<small class="description"><i><%- description %></i></small>'
;
...
...
app/assets/stylesheets/framework/markdown_area.scss
View file @
78b044a1
...
@@ -192,6 +192,17 @@
...
@@ -192,6 +192,17 @@
overflow-y
:
auto
;
overflow-y
:
auto
;
overflow-x
:
hidden
;
overflow-x
:
hidden
;
.name
,
small
.aliases
,
small
.params
{
float
:
left
;
}
small
.aliases
,
small
.params
{
padding
:
2px
5px
;
}
small
.description
{
small
.description
{
float
:
right
;
float
:
right
;
padding
:
3px
5px
;
padding
:
3px
5px
;
...
@@ -209,6 +220,7 @@
...
@@ -209,6 +220,7 @@
}
}
ul
>
li
{
ul
>
li
{
@include
clearfix
;
white-space
:
nowrap
;
white-space
:
nowrap
;
}
}
...
...
changelogs/unreleased/40190-fix-slash-commands-dropdown-description-mis-alignement-on-firefox.yml
0 → 100644
View file @
78b044a1
---
title
:
"
Fix
slash
commands
dropdown
description
mis-alignment
on
Firefox"
merge_request
:
16125
author
:
Maurizio De Santis
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment