Remove unnecessary require_relative calls from service classes

Rails by default use autoload for all dirs from app folder. require_relative not needed. See ActiveSupport::Dependencies.autoload_paths

Remove unnecessary require_relative calls from service classes
724864ee · Semyon Pupkov · 78e34d8a · 724864ee · 724864ee · 724864ee
Commit 724864ee authored Nov 19, 2016 by Semyon Pupkov
16 changed files
--- a/app/services/after_branch_delete_service.rb
+++ b/app/services/after_branch_delete_service.rb
-require_relative 'base_service'
-
 ##
 # Branch can be deleted either by DeleteBranchService
 # or by GitPushService.

--- a/app/services/create_branch_service.rb
+++ b/app/services/create_branch_service.rb
-require_relative 'base_service'
-
 class CreateBranchService < BaseService
  def execute(branch_name, ref, source_project: @project)
    valid_branch = Gitlab::GitRefValidator.validate(branch_name)

--- a/app/services/create_deployment_service.rb
+++ b/app/services/create_deployment_service.rb
-require_relative 'base_service'
-
 class CreateDeploymentService < BaseService
  def execute(deployable = nil)
    return unless executable?

--- a/app/services/create_release_service.rb
+++ b/app/services/create_release_service.rb
-require_relative 'base_service'
-
 class CreateReleaseService < BaseService
  def execute(tag_name, release_description)
    repository = project.repository

--- a/app/services/create_tag_service.rb
+++ b/app/services/create_tag_service.rb
-require_relative 'base_service'
-
 class CreateTagService < BaseService
  def execute(tag_name, target, message, release_description = nil)
    valid_tag = Gitlab::GitRefValidator.validate(tag_name)

--- a/app/services/delete_branch_service.rb
+++ b/app/services/delete_branch_service.rb
-require_relative 'base_service'
-
 class DeleteBranchService < BaseService
  def execute(branch_name)
    repository = project.repository

--- a/app/services/delete_merged_branches_service.rb
+++ b/app/services/delete_merged_branches_service.rb
-require_relative 'base_service'
-
 class DeleteMergedBranchesService < BaseService
  def async_execute
    DeleteMergedBranchesWorker.perform_async(project.id, current_user.id)

--- a/app/services/delete_tag_service.rb
+++ b/app/services/delete_tag_service.rb
-require_relative 'base_service'
-
 class DeleteTagService < BaseService
  def execute(tag_name)
    repository = project.repository

--- a/app/services/files/create_dir_service.rb
+++ b/app/services/files/create_dir_service.rb
-require_relative "base_service"
-
 module Files
  class CreateDirService < Files::BaseService
    def commit

--- a/app/services/files/create_service.rb
+++ b/app/services/files/create_service.rb
-require_relative "base_service"
-
 module Files
  class CreateService < Files::BaseService
    def commit

--- a/app/services/files/delete_service.rb
+++ b/app/services/files/delete_service.rb
-require_relative "base_service"
-
 module Files
  class DeleteService < Files::BaseService
    def commit

--- a/app/services/files/multi_service.rb
+++ b/app/services/files/multi_service.rb
-require_relative "base_service"
-
 module Files
  class MultiService < Files::BaseService
    class FileChangedError < StandardError; end

--- a/app/services/files/update_service.rb
+++ b/app/services/files/update_service.rb
-require_relative "base_service"
-
 module Files
  class UpdateService < Files::BaseService
    class FileChangedError < StandardError; end

--- a/app/services/merge_requests/update_service.rb
+++ b/app/services/merge_requests/update_service.rb
-require_relative 'base_service'
-require_relative 'reopen_service'
-require_relative 'close_service'
-
 module MergeRequests
  class UpdateService < MergeRequests::BaseService
    def execute(merge_request)

--- a/app/services/update_release_service.rb
+++ b/app/services/update_release_service.rb
-require_relative 'base_service'
-
 class UpdateReleaseService < BaseService
  def execute(tag_name, release_description)
    repository = project.repository

--- a/changelogs/unreleased/remove-require-from-services.yml
+++ b/changelogs/unreleased/remove-require-from-services.yml
+---
+title: 'Remove unnecessary require_relative calls from service classes'
+merge_request: '7601'
+author: Semyon Pupkov