Revert "Merge branch 'sidebar-cache-updates' into 'master'"

app/models/issue.rb

@@ -269,13 +269,7 @@ class Issue < ActiveRecord::Base
     end
   end
 
-  def update_project_counter_caches?
-    state_changed? || confidential_changed?
-  end
-
   def update_project_counter_caches
-    return unless update_project_counter_caches?
-
     Projects::OpenIssuesCountService.new(project).refresh_cache
   end
 

app/models/merge_request.rb

@@ -942,13 +942,7 @@ class MergeRequest < ActiveRecord::Base
     true
   end
 
-  def update_project_counter_caches?
-    state_changed?
-  end
-
   def update_project_counter_caches
-    return unless update_project_counter_caches?
-
     Projects::OpenMergeRequestsCountService.new(target_project).refresh_cache
   end
 

changelogs/unreleased/sidebar-cache-updates.yml

----
-title: Only update the sidebar count caches when needed
-merge_request:
-author:
-type: other

spec/models/issue_spec.rb

@@ -773,22 +773,4 @@ describe Issue do
       expect(described_class.public_only).to eq([public_issue])
     end
   end
-
-  describe '#update_project_counter_caches?' do
-    it 'returns true when the state changes' do
-      subject.state = 'closed'
-
-      expect(subject.update_project_counter_caches?).to eq(true)
-    end
-
-    it 'returns true when the confidential flag changes' do
-      subject.confidential = true
-
-      expect(subject.update_project_counter_caches?).to eq(true)
-    end
-
-    it 'returns false when the state or confidential flag did not change' do
-      expect(subject.update_project_counter_caches?).to eq(false)
-    end
-  end
 end

spec/models/merge_request_spec.rb

@@ -1694,25 +1694,4 @@ describe MergeRequest do
       expect(subject.ref_fetched?).to be_falsey
     end
   end
-
-  describe 'removing a merge request' do
-    it 'refreshes the number of open merge requests of the target project' do
-      project = subject.target_project
-
-      expect { subject.destroy }
-        .to change { project.open_merge_requests_count }.from(1).to(0)
-    end
-  end
-
-  describe '#update_project_counter_caches?' do
-    it 'returns true when the state changes' do
-      subject.state = 'closed'
-
-      expect(subject.update_project_counter_caches?).to eq(true)
-    end
-
-    it 'returns false when the state did not change' do
-      expect(subject.update_project_counter_caches?).to eq(false)
-    end
-  end
 end