Fix a logic error in ProjectTeam#fetch_invited_members

We were calling `.where` and `.send` on the relation, but never doing anything with the return value, resulting in proper access-level filtering never being of any consequence.

Fix a logic error in ProjectTeam#fetch_invited_members
6f558121 · Robert Speicher · b7b41d1f · 6f558121 · 6f558121
Commit 6f558121 authored Sep 20, 2016 by Robert Speicher
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

project_team.rb app/models/project_team.rb +2 -2

project_team_spec.rb spec/models/project_team_spec.rb +1 -0

No files found.
--- a/app/models/project_team.rb
+++ b/app/models/project_team.rb
@@ -248,9 +248,9 @@ class ProjectTeam
        # group access is developers we need to provide
        # both group master, developers as devs
        if int_level == group_link.group_access
-          im.where("access_level >= ?)", group_link.group_access)
+          im = im.where("access_level >= ?", group_link.group_access)
        else
-          im.send(level)
+          im = im.send(level)
        end
      end


--- a/spec/models/project_team_spec.rb
+++ b/spec/models/project_team_spec.rb
@@ -111,6 +111,7 @@ describe ProjectTeam, models: true do
          group_access: Gitlab::Access::REPORTER
        )

+        expect(project.team.guests).to be_empty
        expect(project.team.reporters).to contain_exactly(group_member.user)
      end
    end