Merge branch 'confidential-issue-notes' into 'master'

Project members with guest role can't access notes on confidential issues Related issues: - https://gitlab.com/gitlab-org/gitlab-ce/issues/18535 - https://gitlab.com/gitlab-org/gitlab-ce/issues/14787 See merge request !1971

Merge branch 'confidential-issue-notes' into 'master'
6e05270b · Robert Speicher · d8563bd6 · 7b4e0739 · 6e05270b
Commit 6e05270b authored Jun 16, 2016 by Robert Speicher
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

notes_finder_spec.rb spec/finders/notes_finder_spec.rb +7 -0

No files found.
--- a/spec/finders/notes_finder_spec.rb
+++ b/spec/finders/notes_finder_spec.rb
@@ -49,6 +49,13 @@ describe NotesFinder do
        user = create(:user)
        expect { NotesFinder.new.execute(project, user, params) }.to raise_error(ActiveRecord::RecordNotFound)
      end
+
+      it 'raises an error for project members with guest role' do
+        user = create(:user)
+        project.team << [user, :guest]
+
+        expect { NotesFinder.new.execute(project, user, params) }.to raise_error(ActiveRecord::RecordNotFound)
+      end
    end
  end
 end