No need to check project because:

sent_notification.project would never be nil, and we also have already checked message_project before entering process_create_issue.

No need to check project because:
68b5ded0 · Lin Jen-Shin · 034e752a · 68b5ded0
Commit 68b5ded0 authored Mar 31, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

receiver.rb lib/gitlab/email/receiver.rb +1 -2

No files found.
--- a/lib/gitlab/email/receiver.rb
+++ b/lib/gitlab/email/receiver.rb
@@ -79,8 +79,7 @@ module Gitlab
        raise UserNotFoundError unless author
        raise UserBlockedError if author.blocked?
        # TODO: Give project not found error if author cannot read project
-        raise UserNotAuthorizedError if project.nil? ||
-                                        !author.can?(permission, project)
+        raise UserNotAuthorizedError unless author.can?(permission, project)
      end

      # Find the first matched user in database from email From: section