BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 6075d7aa by Rémy Coutable
Options

Merge branch 'update-cr-docs' into 'master'

Fix links in code review docs See merge request !11207
parents 388641ae 4b463dcb
Showing with 10 additions and 5 deletions
doc/development/code_review.md
...@@ -6,18 +6,20 @@ There are a few rules to get your merge request accepted: ...@@ -6,18 +6,20 @@ There are a few rules to get your merge request accepted:
1. Your merge request should only be **merged by a [maintainer][team]**. 1. Your merge request should only be **merged by a [maintainer][team]**.
1. If your merge request includes only backend changes [^1], it must be 1. If your merge request includes only backend changes [^1], it must be
**approved by a [backend maintainer][team]**. **approved by a [backend maintainer][projects]**.
1. If your merge request includes only frontend changes [^1], it must be 1. If your merge request includes only frontend changes [^1], it must be
**approved by a [frontend maintainer][team]**. **approved by a [frontend maintainer][projects]**.
1. If your merge request includes frontend and backend changes [^1], it must 1. If your merge request includes frontend and backend changes [^1], it must
be **approved by a [frontend and a backend maintainer][team]**. be **approved by a [frontend and a backend maintainer][projects]**.
1. To lower the amount of merge requests maintainers need to review, you can 1. To lower the amount of merge requests maintainers need to review, you can
ask or assign any [reviewers][team] for a first review. ask or assign any [reviewers][projects] for a first review.
1. If you need some guidance (e.g. it's your first merge request), feel free 1. If you need some guidance (e.g. it's your first merge request), feel free
to ask one of the [Merge request coaches][team]. to ask one of the [Merge request coaches][team].
1. The reviewer will assign the merge request to a maintainer once the 1. The reviewer will assign the merge request to a maintainer once the
reviewer is satisfied with the state of the merge request. reviewer is satisfied with the state of the merge request.
For more guidance, see [CONTRIBUTING.md](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md).
## Best practices ## Best practices
This guide contains advice and best practices for performing code review, and This guide contains advice and best practices for performing code review, and
...@@ -30,7 +32,7 @@ code is effective, understandable, and maintainable. ...@@ -30,7 +32,7 @@ code is effective, understandable, and maintainable.
Any developer can, and is encouraged to, perform code review on merge requests Any developer can, and is encouraged to, perform code review on merge requests
of colleagues and contributors. However, the final decision to accept a merge of colleagues and contributors. However, the final decision to accept a merge
request is up to one the project's maintainers, denoted on the request is up to one the project's maintainers, denoted on the
[team page](https://about.gitlab.com/team). [engineering projects][projects].
### Everyone ### Everyone
...@@ -140,3 +142,6 @@ Largely based on the [thoughtbot code review guide]. ...@@ -140,3 +142,6 @@ Largely based on the [thoughtbot code review guide].
--- ---
[Return to Development documentation](README.md) [Return to Development documentation](README.md)
[projects]: https://about.gitlab.com/handbook/engineering/projects/
[team]: https://about.gitlab.com/team/
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment