Fix double event and xhr request call on MR page !7298

On page merge_requests/n/diffs and merge_requests/n/commits 'shown.bs.tab' event triggers twice when tab is loading which lead to extra ajax request for data each time. This commit prevent this event from triggering twice when tab is loading.

Fix double event and xhr request call on MR page !7298
5b876592 · Yar · YarNayar · 7957b204 · 5b876592 · 5b876592
Commit 5b876592 authored Nov 13, 2016 by Yar Committed by YarNayar Nov 15, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

merge_request_tabs.js app/assets/javascripts/merge_request_tabs.js +2 -1

24010-double-event-trigger.yml changelogs/unreleased/24010-double-event-trigger.yml +4 -0

No files found.
--- a/app/assets/javascripts/merge_request_tabs.js
+++ b/app/assets/javascripts/merge_request_tabs.js
@@ -145,7 +145,8 @@
      if (action === 'show') {
        action = 'notes';
      }
-      $(".merge-request-tabs a[data-action='" + action + "']").tab('show').trigger('shown.bs.tab');
+      // important note: the .tab('show') method triggers 'shown.bs.tab' event itself
+      $(".merge-request-tabs a[data-action='" + action + "']").tab('show');
    };

    // Replaces the current Merge Request-specific action in the URL with a new one

--- a/changelogs/unreleased/24010-double-event-trigger.yml
+++ b/changelogs/unreleased/24010-double-event-trigger.yml
+---
+title: Fix double event and ajax request call on MR page
+merge_request: 7298
+author: YarNayar