Fix jQuery data attribute caching issue casuing expanding issues

Command | Result $link.data('lineType') | '' $link.data('line-type') | '' $link.attr('data-line-type') | 'new' $link[0].dataset.lineType | 'new'

Fix jQuery data attribute caching issue casuing expanding issues
5563bf9c · Eric Eastwood · 3c45906b · 5563bf9c
Commit 5563bf9c authored May 22, 2017 by Eric Eastwood
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

notes.js app/assets/javascripts/notes.js +3 -2

No files found.
--- a/app/assets/javascripts/notes.js
+++ b/app/assets/javascripts/notes.js
@@ -858,11 +858,12 @@ const normalizeNewlines = function(str) {

    Notes.prototype.onAddDiffNote = function(e) {
      e.preventDefault();
-      const $link = $(e.currentTarget || e.target);
+      const link = e.currentTarget || e.target;
+      const $link = $(link);
      const showReplyInput = !$link.hasClass('js-diff-comment-avatar');
      this.toggleDiffNote({
        target: $link,
-        lineType: $link.data('lineType'),
+        lineType: link.dataset.lineType,
        showReplyInput
      });
    };