Remove N+1 queries when checking nodes visible to user

N in this case is low, as it's the number of distinct projects referenced from MRs, rather than the number of MRs referenced (issues use their own optimization). Still, on issues or MRs which are often referenced from MRs, it will save a few queries.

Remove N+1 queries when checking nodes visible to user
52d049b4 · Sean McGivern · 6277bda6 · 52d049b4 · 52d049b4
Commit 52d049b4 authored May 02, 2017 by Sean McGivern
Showing with 6 additions and 1 deletion

fix-n-plus-one-project-features.yml changelogs/unreleased/fix-n-plus-one-project-features.yml +4 -0

merge_request_parser.rb lib/banzai/reference_parser/merge_request_parser.rb +2 -1

No files found.
--- a/changelogs/unreleased/fix-n-plus-one-project-features.yml
+++ b/changelogs/unreleased/fix-n-plus-one-project-features.yml
+---
+title: Remove N+1 queries in processing MR references
+merge_request:
+author:
--- a/lib/banzai/reference_parser/merge_request_parser.rb
+++ b/lib/banzai/reference_parser/merge_request_parser.rb
@@ -33,7 +33,8 @@ module Banzai
                { namespace: :owner },
                { group: [:owners, :group_members] },
                :invited_groups,
-                :project_members
+                :project_members,
+                :project_feature
              ]
            }),
          self.class.data_attribute