BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
4fbe044b
Commit
4fbe044b
authored
Aug 17, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use switch case in a helper, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13988401
parent
ee33b3e6
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
7 deletions
+18
-7
artifacts_controller.rb
app/controllers/projects/artifacts_controller.rb
+3
-7
gitlab_routing_helper.rb
app/helpers/gitlab_routing_helper.rb
+15
-0
No files found.
app/controllers/projects/artifacts_controller.rb
View file @
4fbe044b
...
...
@@ -35,14 +35,10 @@ class Projects::ArtifactsController < Projects::ApplicationController
end
def
latest_succeeded
path
=
params
[
:path
]
target_url
=
artifacts_action_url
(
params
[
:path
],
project
,
build
)
if
%w[download browse file]
.
include?
(
path
)
redirect_to
send
(
"
#{
path
}
_namespace_project_build_artifacts_url"
,
project
.
namespace
,
project
,
build
)
if
target_url
redirect_to
(
target_url
)
else
render_404
end
...
...
app/helpers/gitlab_routing_helper.rb
View file @
4fbe044b
...
...
@@ -149,4 +149,19 @@ module GitlabRoutingHelper
def
resend_invite_group_member_path
(
group_member
,
*
args
)
resend_invite_group_group_member_path
(
group_member
.
source
,
group_member
)
end
# Artifacts
def
artifacts_action_url
(
path
,
project
,
build
)
args
=
[
project
.
namespace
,
project
,
build
]
case
path
when
'download'
download_namespace_project_build_artifacts_url
(
*
args
)
when
'browse'
browse_namespace_project_build_artifacts_url
(
*
args
)
when
'file'
file_namespace_project_build_artifacts_url
(
*
args
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment