BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
4eed3481
Commit
4eed3481
authored
Mar 23, 2017
by
Sean McGivern
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch '24215-closed-issues-board' into 'master'
Display all closed issues in “done” board list Closes #24215 See merge request !10173
parents
ef91f83d
7d7cd914
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
list_service.rb
app/services/boards/issues/list_service.rb
+1
-1
24215-closed-issues-board.yml
changelogs/unreleased/24215-closed-issues-board.yml
+4
-0
list_service_spec.rb
spec/services/boards/issues/list_service_spec.rb
+2
-1
No files found.
app/services/boards/issues/list_service.rb
View file @
4eed3481
...
@@ -3,7 +3,7 @@ module Boards
...
@@ -3,7 +3,7 @@ module Boards
class
ListService
<
BaseService
class
ListService
<
BaseService
def
execute
def
execute
issues
=
IssuesFinder
.
new
(
current_user
,
filter_params
).
execute
issues
=
IssuesFinder
.
new
(
current_user
,
filter_params
).
execute
issues
=
without_board_labels
(
issues
)
unless
movable_list?
issues
=
without_board_labels
(
issues
)
unless
list
issues
=
with_list_label
(
issues
)
if
movable_list?
issues
=
with_list_label
(
issues
)
if
movable_list?
issues
.
order_by_position_and_priority
issues
.
order_by_position_and_priority
end
end
...
...
changelogs/unreleased/24215-closed-issues-board.yml
0 → 100644
View file @
4eed3481
---
title
:
Display all closed issues in “done” board list
merge_request
:
author
:
spec/services/boards/issues/list_service_spec.rb
View file @
4eed3481
...
@@ -30,6 +30,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -30,6 +30,7 @@ describe Boards::Issues::ListService, services: true do
let!
(
:closed_issue2
)
{
create
(
:labeled_issue
,
:closed
,
project:
project
,
labels:
[
p3
])
}
let!
(
:closed_issue2
)
{
create
(
:labeled_issue
,
:closed
,
project:
project
,
labels:
[
p3
])
}
let!
(
:closed_issue3
)
{
create
(
:issue
,
:closed
,
project:
project
)
}
let!
(
:closed_issue3
)
{
create
(
:issue
,
:closed
,
project:
project
)
}
let!
(
:closed_issue4
)
{
create
(
:labeled_issue
,
:closed
,
project:
project
,
labels:
[
p1
])
}
let!
(
:closed_issue4
)
{
create
(
:labeled_issue
,
:closed
,
project:
project
,
labels:
[
p1
])
}
let!
(
:closed_issue5
)
{
create
(
:labeled_issue
,
:closed
,
project:
project
,
labels:
[
development
])
}
before
do
before
do
project
.
team
<<
[
user
,
:developer
]
project
.
team
<<
[
user
,
:developer
]
...
@@ -57,7 +58,7 @@ describe Boards::Issues::ListService, services: true do
...
@@ -57,7 +58,7 @@ describe Boards::Issues::ListService, services: true do
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
issues
=
described_class
.
new
(
project
,
user
,
params
).
execute
expect
(
issues
).
to
eq
[
closed_issue4
,
closed_issue2
,
closed_issue3
,
closed_issue1
]
expect
(
issues
).
to
eq
[
closed_issue4
,
closed_issue2
,
closed_issue
5
,
closed_issue
3
,
closed_issue1
]
end
end
it
'returns opened issues that have label list applied when listing issues from a label list'
do
it
'returns opened issues that have label list applied when listing issues from a label list'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment