Reset only migration models

So that we could make sure migration tests could run even if geo is not setup in EE. This is because we have a model like this: ``` ruby class Geo::BaseRegistry < ActiveRecord::Base def self.connection raise 'Geo secondary database is not configured' unless Gitlab::Geo.geo_database_configured? super end end ```

Reset only migration models
4d7c072d · Lin Jen-Shin · e8a439ab · 4d7c072d · 4d7c072d
Commit 4d7c072d authored Aug 07, 2017 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 2 deletions

spec_helper.rb spec/spec_helper.rb +2 -2

migrations_helpers.rb spec/support/migrations_helpers.rb +10 -0

No files found.
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -134,13 +134,13 @@ RSpec.configure do |config|
    ActiveRecord::Migrator
      .migrate(migrations_paths, previous_migration.version)
-    ActiveRecord::Base.descendants.each(&:reset_column_information)
+    reset_column_in_migration_models
  end
  config.after(:example, :migration) do
    ActiveRecord::Migrator.migrate(migrations_paths)
-    ActiveRecord::Base.descendants.each(&:reset_column_information)
+    reset_column_in_migration_models
  end
  config.around(:each, :nested_groups) do |example|

--- a/spec/support/migrations_helpers.rb
+++ b/spec/support/migrations_helpers.rb
@@ -15,6 +15,16 @@ module MigrationsHelpers
    ActiveRecord::Migrator.migrations(migrations_paths)
  end
+  def reset_column_in_migration_models
+    described_class.constants.sort.each do |name|
+      const = described_class.const_get(name)
+      if const.is_a?(Class) && const < ActiveRecord::Base
+        const.reset_column_information
+      end
+    end
+  end
  def previous_migration
    migrations.each_cons(2) do |previous, migration|
      break previous if migration.name == described_class.name