Fixing the issue of visiting a project fork url giving 500 error when not signed…

Fixing the issue of visiting a project fork url giving 500 error when not signed in instead of being redirected to the sign in page. The main reason is ApplicationController skips authentication if the project exists. To fix the issue, forced the authentication in ForksController when current_user is nil.

Fixing the issue of visiting a project fork url giving 500 error when not signed…
4acedecc · Cagdas Gerede · bcba8b25 · 4acedecc · 4acedecc
Commit 4acedecc authored Nov 10, 2016 by Cagdas Gerede
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 2 deletions

forks_controller.rb app/controllers/projects/forks_controller.rb +6 -2

fix-singin-redirect-for-fork-new.yml changelogs/unreleased/fix-singin-redirect-for-fork-new.yml +5 -0

No files found.
--- a/app/controllers/projects/forks_controller.rb
+++ b/app/controllers/projects/forks_controller.rb
@@ -29,8 +29,12 @@ class Projects::ForksController < Projects::ApplicationController
  end
  def new
-    @namespaces = current_user.manageable_namespaces
+    if current_user.nil?
-    @namespaces.delete(@project.namespace)
+      authenticate_user!
+    else
+      @namespaces = current_user.manageable_namespaces
+      @namespaces.delete(@project.namespace)
+    end
  end
  def create

--- a/changelogs/unreleased/fix-singin-redirect-for-fork-new.yml
+++ b/changelogs/unreleased/fix-singin-redirect-for-fork-new.yml
+---
+title: Fixing the issue of the project fork url giving 500 when not signed instead
+  of being redirected to sign in page
+merge_request: 
+author: Cagdas Gerede