popover trigger needs to be defined in js init

According to https://github.com/twbs/bootstrap/issues/10547 it's not possible to have the trigger defined on the delegated element, i.e. not defined as a data attribute.

popover trigger needs to be defined in js init
4648d001 · Alexis Reigel · 5013f3a8 · 4648d001 · 4648d001
Commit 4648d001 authored Jun 26, 2017 by Alexis Reigel
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

main.js app/assets/javascripts/main.js +2 -1

commits_helper.rb app/helpers/commits_helper.rb +0 -1

No files found.
--- a/app/assets/javascripts/main.js
+++ b/app/assets/javascripts/main.js
@@ -251,7 +251,8 @@ $(function () {
  });
  // Initialize popovers
  $body.popover({
-    selector: '[data-toggle="popover"]'
+    selector: '[data-toggle="popover"]',
+    trigger: 'focus'
  });
  $('.trigger-submit').on('change', function () {
    return $(this).parents('form').submit();

--- a/app/helpers/commits_helper.rb
+++ b/app/helpers/commits_helper.rb
@@ -283,7 +283,6 @@ module CommitsHelper
      toggle: 'popover',
      html: 'true',
      placement: 'auto bottom',
-      trigger: 'focus',
      title: title,
      content: content
    }