BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit 43b6a3ea by Lin Jen-Shin
Options

Check against type explicit, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173368 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173370
parent 42656104
Showing with 4 additions and 2 deletions
spec/models/build_spec.rb
...@@ -687,8 +687,9 @@ describe Ci::Build, models: true do ...@@ -687,8 +687,9 @@ describe Ci::Build, models: true do
end end
it 'returns empty relation if the build cannot be found' do it 'returns empty relation if the build cannot be found' do
builds = project.latest_successful_builds_for('TAIL').all builds = project.latest_successful_builds_for('TAIL')
expect(builds).to be_kind_of(ActiveRecord::Relation)
expect(builds).to be_empty expect(builds).to be_empty
end end
end end
...@@ -699,8 +700,9 @@ describe Ci::Build, models: true do ...@@ -699,8 +700,9 @@ describe Ci::Build, models: true do
end end
it 'returns empty relation' do it 'returns empty relation' do
builds = project.latest_successful_builds_for('fix').all builds = project.latest_successful_builds_for('fix')
expect(builds).to be_kind_of(ActiveRecord::Relation)
expect(builds).to be_empty expect(builds).to be_empty
end end
end end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment