Check against type explicit, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173368 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347/diffs#note_13173370

Check against type explicit, feedback:
43b6a3ea · Lin Jen-Shin · 42656104 · 43b6a3ea
Commit 43b6a3ea authored Jul 20, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

build_spec.rb spec/models/build_spec.rb +4 -2

No files found.
--- a/spec/models/build_spec.rb
+++ b/spec/models/build_spec.rb
@@ -687,8 +687,9 @@ describe Ci::Build, models: true do
      end

      it 'returns empty relation if the build cannot be found' do
-        builds = project.latest_successful_builds_for('TAIL').all
+        builds = project.latest_successful_builds_for('TAIL')

+        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end
@@ -699,8 +700,9 @@ describe Ci::Build, models: true do
      end

      it 'returns empty relation' do
-        builds = project.latest_successful_builds_for('fix').all
+        builds = project.latest_successful_builds_for('fix')

+        expect(builds).to be_kind_of(ActiveRecord::Relation)
        expect(builds).to be_empty
      end
    end